r? @BoxyUwU

rustbot has assigned @BoxyUwU.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

These commits modify compiler targets.
(See the Target Tier Policy.)

Some changes occurred in src/doc/rustc/src/platform-support

cc @Noratrieb

The previous PR stalled out on concerns of ecosystem breakage, but see this comment for @est31 concluding we can move forward without further mitigation: #125692 (comment)

I would like to nominate this for FCP or whatever the current process is to land these kinds of major toolchain changes.

Landing this update is expected to resolve ongoing issues in the ecosystem with rootless docker images.

I've also drafted a rust-lang blogpost announcing this change (based on the previous musl update's post).

The process for bumping the target baseline of Tier 2 targets is currently a Major Change Proposal + FCP (see Changing target baseline (e.g. minimum Darwin or Windows version bump) part). If you draft an MCP, I'll help with the notifying relevant target maintainers part.

Changing target baseline (e.g. minimum Darwin or Windows version bump)

• Propose using: MCP
• Approve using: FCP
• Write an MCP describing why the target should have a change of baseline and once discussion has concluded, an FCP can be started to approve the change of baseline.

r? @wesleywiser (since you've reviewed the previous attempt)

I have filed an MCP:

• Upgrade *-linux-musl targets to musl 1.2.5 compiler-team#887

Building host compiler plus musl stds for crater run.

@bors try

⌛ Trying commit 1926e11 with merge 1271e16...

💥 Test timed out

@bors2 delegate=try

@Gankra can now perform try builds on this pull request

I've rebased the PR and I think I've fixed:

Just FYI, this pull request effectively only changes the musl version in the musl-cross-make script (which is only used by aarch64 and x86_64), the crosstool-ng configs used by all the other targets still need updating.

In particular we're currently on crosstool-ng 1.27 which defaults to musl 1.2.5, so all that needed to be changed was to remove explicit opt-outs for that version. The only opt-out I could find was for powerpc64le-unknown-linux-musl.

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

If we could get crater to cooperate, that would be great (and I think it seemed to work when I bumped musl last time):

@craterbot run mode=build-and-test name=musl_upgrade_1_2_5_with_getrandom_patch_2 start=try#8de4c7234dd9b97c9d76b58671343fdbbc9a433e+target=x86_64-unknown-linux-musl end=try#c066bf6804adc55193b71afdff6a56922f4a8689+target=x86_64-unknown-linux-musl+patch=getrandom=https://github.com/rust-random/getrandom=backports/v0.2
crates=https://gist.githubusercontent.com/workingjubilee/075aa4757096ce213b76d576f2f92742/raw/197ec4b1e9a09e208b6863172f6a1e9baceaa842/musl-1_2_5-retry-list-4.txt

👌 Experiment musl_upgrade_1_2_5_with_getrandom_patch_2 created and queued.
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

In particular we're currently on crosstool-ng 1.27 which defaults to musl 1.2.5, so all that needed to be changed was to remove explicit opt-outs for that version

I'd recommend still pinning the musl version explicitly so that another crosstool-ng update doesn't unintentionally bump musl to future releases. Effectively, all but 3 targets are now already using 1.2.5 even though that wasn't intended. Pinning the version like is currently done for ppc64le would prevent this.

I'd recommend still pinning the musl version explicitly so that another crosstool-ng update doesn't unintentionally bump musl to future releases. Effectively, all but 3 targets are now already using 1.2.5 even though that wasn't intended. Pinning the version like is currently done for ppc64le would prevent this.

done

🚧 Experiment musl_upgrade_1_2_5_with_getrandom_patch_2 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

🎉 Experiment musl_upgrade_1_2_5_with_getrandom_patch_2 is completed!
📊 11216 regressed and 169 fixed (712125 total)
📊 88679 spurious results on the retry-regessed-list.txt, consider a retry¹ if this is a significant amount.
📰 Open the summary report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

Anything else that needs to be done to merge this?

Looking a few of the random failures, all are related to the (now missing) open64 symbol however, cargo update && cargo build succeeds as newer getrandom and libc libraries resolve this issue. At this point, I don't see any reason to delay this update to wait for more of the ecosystem to update as many of the regressed crates seem to be completely inactive or abandoned.

@rfcbot fcp merge

Team member @wesleywiser has proposed to merge this. The next step is review by the rest of the tagged team members:

• @Mark-Simulacrum
• @Noratrieb
• @SparrowLii
• @cjgillot
• @davidtwco
• @estebank
• @jieyouxu
• @matthewjasper
• @nagisa
• @oli-obk
• @petrochenkov
• @spastorino
• @wesleywiser

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.